search

opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.
16 stars 31 forks source link

Use pre_spawn and post_stop hooks instead of polling for setting up publish service #37

Open vpavlin opened 5 years ago

vpavlin commented 5 years ago

Currently there is a simple service which polls proxy API and updates proxy for published notebooks route. This could be done without polling by using pre_spawn and post_stop hooks in the spawner which would only configure the new proxy route once

i.e. remove https://github.com/AICoE/jupyterhub-ocp-oauth/blob/master/.jupyter/jupyterhub_config.py#L24

add the public route setup/teardown to https://github.com/AICoE/jupyterhub-ocp-oauth/blob/master/.jupyter/jupyterhub_config.py#L303