search

opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.
16 stars 31 forks source link

Add Makefile to build and push the JupyterHub image #52

Closed vpavlin closed 4 years ago

goern commented 4 years ago

@harshad16 could you please check if this is covered by our Tekton pipelines? I think a 'tag-release' workflow would be better than building the image on some random laptop...

goern commented 4 years ago

is this something used for local development? Can we wrap the build and publish up in one of our pipelines?

@AICoE/devops

harshad16 commented 4 years ago

is this something used for local development? Can we wrap the build and publish up in one of our pipelines?

@AICoE/devops

we can enable the pipeline to execute the makefile, however we would need to provide the bots (quay push bot) details to pipeline as the makefile it pushes the image to quay itself. or we can modify the pipeline declarative file so that the pipeline can build the image and push teh image with the requirement of makefile.

vpavlin commented 4 years ago

You can call the makefile just to build the images, but I am not sure it is necessary to use it. I made it as an interim solution so that we at least have the build process documented and reproducible (so far it was just in our heads). I am happy to drop this in favour of something like Tekton Pipeline definition.

harshad16 commented 4 years ago

You can call the makefile just to build the images, but I am not sure it is necessary to use it. I made it as an interim solution so that we at least have the build process documented and reproducible (so far it was just in our heads). I am happy to drop this in favour of something like Tekton Pipeline definition.

ack.

vpavlin commented 4 years ago

We now have Thoth pipelines setup, so we do not need this anymore