opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.
16 stars 31 forks source link

Find new images (imagestreams) for JH w/o restarting the JH pod. #67

Open martinpovolny opened 3 years ago

martinpovolny commented 3 years ago

Is your feature request related to a problem? Please describe.

To get new notebooks to be available in the "Spawner options" one needs to restart the jupyterhub.

jh-images-2020-11-16_16-26

That's inconvenient at least and given JH user's in general need not have the permission to restart the JH pod it means that people might not be able to add their images at all.

Reference to relevant code:

https://github.com/opendatahub-io/jupyterhub-odh/blob/master/.jupyter/jupyterhub_config.py#L145,

https://github.com/opendatahub-io/jupyterhub-singleuser-profiles/blob/master/jupyterhub_singleuser_profiles/images.py

Describe the solution you'd like

I'd like to see new images in the drop-down automatically w/o restarting anything.

Either watch for changes on imagestreams and check them for the needed label or check for them when building the "Spawn Server" screen.

Additional context

I have a feeling that @vpavlin mentioned that this is being resolved somewhere, but I'd love to track this.

FYI @tumido