Closed wseaton closed 3 years ago
I was a little worried about the edge case where the environment variable is not set, eg. will the hub pod fail to start if a service is improperly specified? So added a check.
/lgtm
Tested this with the corresponding odh-manifests PR and it appears to be working as intended.
@vpavlin Do we need to create a SPIKE to determine if there is a "proper" way to implement this in JH?
No, I think this is ok, let's go with this for now. We can always revisit it
see https://github.com/opendatahub-io/odh-manifests/pull/330