search

opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.
16 stars 31 forks source link

Check groups based on length #79

Closed vpavlin closed 3 years ago

vpavlin commented 3 years ago

Related Issues and Dependencies

…

This introduces a breaking change

This Pull Request implements

The original code was safe in case when the env vars did not exist or contained the list of groups, but not in case where they exist and are empty.

This PR fixes that - empty env vars are treated the same as if they do not exist.

Description

vpavlin commented 3 years ago

@wseaton Can you please take a look?

vpavlin commented 3 years ago

Closing this after discussion with @wseaton - I have not realized '' and None are treated the same in the if condition