search

opendatahub-io-contrib / workbench-images

Various custom Workbenches and Runtimes for Open Data Hub and OpenShift Data Science
MIT License
35 stars 23 forks source link

Add bc to the list of dependencies for the interactive image builder #52

Closed koep closed 1 month ago

koep commented 6 months ago

Running interactive-image-builder.sh without bc results in various errors, including:

Try 'sleep --help' for more information.
helper-functions: line 154: bc: command not found
shalberd commented 3 months ago

@harshad16 100% agree with this, just ran into this today on a fresh Linux system. In my view, we can merge this.

shalberd commented 3 months ago

strictly speaking, make is also necessary.

i.e. for a new own release with a later scl centos python case image

https://github.com/opendatahub-io-contrib/workbench-images/issues/50#issuecomment-1931400157

we might also want to document in this section "Building a current/up-to-date base image locally to use in interactive image builder for a given release name and release date"

Before running interactive image builder, ensure you have the most recent base images built locally:

cd base
make all RELEASE=2024a DATE=20240513

or possibly, when running podman and the toolchain in general on Windows Subsystem for Linux:

cd base
sudo make all RELEASE=2024a DATE=20240513

will produce two base images python 3.9 and python 3.11 with said release and date, visible in podman images.

guimou commented 1 month ago

@koep Sorry, took me a long time to review this, but I will gradually start working again on this project.