opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
11 stars 19 forks source link

CI for pull requests #133

Open adelton opened 1 year ago

adelton commented 1 year ago

As a contributor to this repo, I'd like to have an ability to run an automated CI workflow/pipeline on my my pull requests to make sure I do not break things.

Initiating the tests might be manual to avoid wasting resources.

piotrpdev commented 1 year ago

We talked about using Prow for this in one of the meetings, probably worth looking into. It might be better to wait until the PoC is in at least a somewhat stable state before doing this though.

adelton commented 1 year ago

Actually, especially for refactorings like https://github.com/opendatahub-io/ai-edge/pull/131 I would have liked to be able to use some automation to confirm that I don't break things.

For times when the PoC is more stable, https://github.com/opendatahub-io/ai-edge/issues/134 is more applicable.

adelton commented 1 year ago

As for the Prow link -- does it have some information there how to get hooked to https://prow.ci.openshift.org/? I only scanned those pages briefly but it seems like a documentation about setting up Prow but I'd much rather just hook to whatever existing instance is already out there. I wonder if https://github.com/openshift/test-infra is what we are looking for, specifically https://github.com/openshift/test-infra/blob/master/prow/jobs.md.

adelton commented 1 year ago

Actually, does Open Data Hub use Prow in any way?

piotrpdev commented 1 year ago

Looks like it does: https://prow.ci.openshift.org/?repo=opendatahub-io%2Fodh-dashboard

adelton commented 1 year ago

Ah, so folks from our peer team(s) should be able to give us some hints how to onboard us.

piotrpdev commented 1 year ago

hmm, maybe something like these?

https://github.com/openshift/release/tree/master/ci-operator/jobs/opendatahub-io/odh-dashboard https://github.com/openshift/release/tree/master/ci-operator/config/opendatahub-io/odh-dashboard

piotrpdev commented 1 year ago

Great, looks like @LaVLaS knows how 🥳 https://github.com/openshift/release/pull/30719