search

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
9 stars 18 forks source link

[BUG]: For `bike-rentals`, more than the `aws-bucket-name` needs to be changed to test S3 #174

Open adelton opened 10 months ago

adelton commented 10 months ago

Details

Describe the bug

The https://github.com/opendatahub-io/ai-edge/pull/112 changed the default parameters in build-container-image-pipelinerun-bike-rentals.yaml to fetch from git but the section https://github.com/opendatahub-io/ai-edge/blob/main/pipelines/README.md#for-s3-fetch still says

Update the aws-bucket-name parameter value from its default rhoai-edge-models in build-container-image-pipelinerun-bike-rentals.yaml and/or build-container-image-pipelinerun-tensorflow-housing.yaml to match your S3 bucket name.

To Reproduce

Follow the https://github.com/opendatahub-io/ai-edge/blob/main/pipelines/README.md and try to fetch from S3 by only changing the aws-bucket-name.

The PipelineRun will still show that git-clone-model-repo was run.

Expected behavior

The documentation should be clear about what the repository demonstrates out of box, with minimal changes, and how to achieve the alternate behaviour.

Screenshots (if applicable)