Closed piotrpdev closed 9 months ago
Deploying locally worked for me with all of the pipeline results accurately listed upon successful execution. Just have one question about the test-endpoint
change in the PipelineRun
@LaVLaS done
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LaVLaS, piotrpdev
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Description
Changes the GitOps pipeline and the new E2E pipeline to emit metadata as Pipeline Results.
See [RHOAIENG-289] for more info.
How Has This Been Tested?
OpenShift Local/CRC on my machine, with both git and s3, on my fork. I haven't tested if the old pipelines still work but they should since they use separate tasks.
Typical E2E pipeline results
```yaml pipelineResults: - name: git-model-fetched-commit value: f89e2bc61e6ff7f539c52fded3a2bdc991a55b7c - name: git-model-fetched-url value: 'https://github.com/piotrpdev/ai-edge.git' - name: git-model-fetched-commit-epoch value: '1702404808' - name: git-containerfile-fetched-commit value: f89e2bc61e6ff7f539c52fded3a2bdc991a55b7c - name: git-containerfile-fetched-url value: 'https://github.com/piotrpdev/ai-edge' - name: git-containerfile-fetched-commit-epoch value: '1702404808' - name: model-files-size value: | 2084 - name: model-files-list value: | MLmodel README.md conda.yaml convert_csv_to_json.py dataset.csv python_env.yaml requirements.txt tf2model/ - name: internal-registry-url value: > image-registry.openshift-image-registry.svc:5000/pplaczek-pipeline-dev/tensorflow-housing:1 - name: target-registry-url value: quay.io/pplaczek/tensorflow-housing - name: internal-image-url value: >- image-registry.openshift-image-registry.svc:5000/pplaczek-pipeline-dev/tensorflow-housing@sha256:0cc9a636c2f18b0f15224a234995ecd27a3dc2e5eb7ffefc8ecfd72c099da31f - name: target-image-url value: >- quay.io/pplaczek/tensorflow-housing:1-fa9e93e0-c66c-4075-9333-61769420f102 - name: internal-image-size value: '126507187' - name: buildah-sha value: 'sha256:0cc9a636c2f18b0f15224a234995ecd27a3dc2e5eb7ffefc8ecfd72c099da31f' - name: model-name value: tensorflow-housing - name: model-version value: '1' - name: internal-image-created-at value: '2023-12-12T18:39:25Z' - name: internal-image-buildah-version value: 1.24.2 ```Typical GitOps pipeline results
```yaml pipelineResults: - name: target-registry-url value: quay.io/pplaczek/tensorflow-housing - name: image-sha value: 'sha256:0cc9a636c2f18b0f15224a234995ecd27a3dc2e5eb7ffefc8ecfd72c099da31f' - name: pr-url value: 'https://github.com/piotrpdev/ai-edge/pull/5' ```Merge criteria: