RHOAIENG-183: Use ODH OpenVino image, and other fixes

grdryn commented 7 months ago

JIRA: https://issues.redhat.com/browse/RHOAIENG-183

Description

Use ODH OpenVino image in base Containerfile The source for that image is available at https://github.com/opendatahub-io/openvino_model_server I also squashed a coupld of RUN commands into one in that Containerfile.
Use a consistent default for MODEL_DIR in Containerfiles I don't know whether it's the best value, but the previous on in the OpenVino Containerfile seemed too specific to the tensorflow example model.
This makes it easier to use the same example curl command to test that the image built correctly, whether from our Pipeline or using the example podman run in this README.
- Use ODH OpenVino base image
- Use same REST port as pipeline Containerfiles use (8080)
- Use onnx-mnist as the name rather than onnx_mnist
- Use Podman in examples 🦭
Add OpenVino PipelineRun example for aiedge-e2e This also renames the pre-existing one to make it clear that it's for the bike-rentals example, and updates the README to mention both.

How Has This Been Tested?

The included PipelineRun file for the tensorflow-housing example was created to test this change. Additionally, I ran the secondary example models locally with Podman.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci-robot commented 7 months ago

@grdryn: This pull request references RHOAIENG-183 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/202): > >JIRA: https://issues.redhat.com/browse/RHOAIENG-183 > >## Description > >- Use ODH OpenVino image in base Containerfile >The source for that image is available at https://github.com/opendatahub-io/openvino_model_server >I also squashed a coupld of RUN commands into one in that Containerfile. >- Use a consistent default for MODEL_DIR in Containerfiles >I don't know whether it's the best value, but the previous on in the OpenVino Containerfile seemed too specific to the tensorflow example model. >- This makes it easier to use the same example curl command to test that the image built correctly, whether from our Pipeline or using the example `podman run` in this README. > - Use ODH OpenVino base image > - Use same REST port as pipeline Containerfiles use (8080) > - Use onnx-mnist as the name rather than onnx_mnist > - Use Podman in examples 🦭 >- Add OpenVino PipelineRun example for aiedge-e2e >This also renames the pre-existing one to make it clear that it's for the bike-rentals example, and updates the README to mention both. > >## How Has This Been Tested? > > > >- The included PipelineRun file for the tensorflow-housing example was created to test this change. Additionally, I ran the secondary example models locally with Podman. > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

MarianMacik commented 7 months ago

@davidesalerno @grdryn are we fine with approving this? If so, I can go ahead.

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn, MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik,grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / ai-edge