opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
9 stars 18 forks source link

Makefile: Add support to include vars from local env var file #206

Closed LaVLaS closed 7 months ago

LaVLaS commented 7 months ago

Description

Adds support for passing Make variables via a local env var file instead of on the command line

How Has This Been Tested?

Successfully ran make against go-test and go-test-setup without any variables on the CLI

Merge criteria:

CI runs and local make execution works without any issues

MarianMacik commented 7 months ago

/retest

grdryn commented 7 months ago

An alternative to consider might be direnv.

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [LaVLaS,grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment