Heredoc in containerfile is supported only since 1.33.0

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases

Apache License 2.0

9 stars 18 forks source link

Heredoc in containerfile is supported only since 1.33.0 #207

Closed MarianMacik closed 7 months ago

MarianMacik commented 7 months ago

Description

Switches heredoc to a one-liner so we have just one layer. Heredoc is only compatible in Buildah 1.33.0 but the latest rhel8 image has just 1.31.
Updates the buildah image to the latest one.

How Has This Been Tested?

Locally, PR check currently doesn't run the containerfiles from the same branch. I will investigate whether it is possible to obtain the PR's author and fork.

Because of that PR check will be failing.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

grdryn commented 7 months ago

/lgtm

MarianMacik commented 7 months ago

/override ci/prow/test-ai-edge

openshift-ci[bot] commented 7 months ago

@MarianMacik: Overrode contexts on behalf of MarianMacik: ci/prow/test-ai-edge

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/207#issuecomment-1946308263): >/override ci/prow/test-ai-edge Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.