RHOAIENG-1119: Don't rely on imagestream in image info task

grdryn commented 6 months ago

This PR stacks upon #215 as another preparatory commit for RHOAIENG-1119. It will be held until that one is merged, but it can still be reviewed, by just reviewing the new commit(s).

Description

With this change, we now get info for the image from the image metadata using skopeo inspect, rather than from the ImageStream resource in OpenShift.

How Has This Been Tested?

make go-test runs successfully
Example pipelineruns executed manually with success

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-2758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/217): >This PR stacks upon #215 as another preparatory commit for [RHOAIENG-2758](https://issues.redhat.com//browse/RHOAIENG-2758). It will be held until that one is merged, but it can still be reviewed, by just reviewing the new commit(s). > >## Description >With this change, we now get info for the image from the image metadata using `skopeo inspect`, rather than from the ImageStream resource in OpenShift. > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-2758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/217): >This PR stacks upon #215 as another preparatory commit for [RHOAIENG-2758](https://issues.redhat.com//browse/RHOAIENG-2758). It will be held until that one is merged, but it can still be reviewed, by just reviewing the new commit(s). > >## Description >With this change, we now get info for the image from the image metadata using `skopeo inspect`, rather than from the ImageStream resource in OpenShift. > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

grdryn commented 6 months ago

/hold until #215 is merged.

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-2758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/217): >This PR stacks upon #215 as another preparatory commit for [RHOAIENG-2758](https://issues.redhat.com//browse/RHOAIENG-2758). It will be held until that one is merged, but it can still be reviewed, by just reviewing the new commit(s). > >## Description >With this change, we now get info for the image from the image metadata using `skopeo inspect`, rather than from the ImageStream resource in OpenShift. > >## How Has This Been Tested? > > > >- `make go-test` runs successfully >- Example pipelineruns executed manually with success > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

grdryn commented 6 months ago

/unhold

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/217): >This PR stacks upon #215 as another preparatory commit for [RHOAIENG-2758](https://issues.redhat.com//browse/RHOAIENG-2758). It will be held until that one is merged, but it can still be reviewed, by just reviewing the new commit(s). > >## Description >With this change, we now get info for the image from the image metadata using `skopeo inspect`, rather than from the ImageStream resource in OpenShift. > >## How Has This Been Tested? > > > >- `make go-test` runs successfully >- Example pipelineruns executed manually with success > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/217): >This PR stacks upon #215 as another preparatory commit for [RHOAIENG-1119](https://issues.redhat.com//browse/RHOAIENG-1119). It will be held until that one is merged, but it can still be reviewed, by just reviewing the new commit(s). > >## Description >With this change, we now get info for the image from the image metadata using `skopeo inspect`, rather than from the ImageStream resource in OpenShift. > >## How Has This Been Tested? > > > >- `make go-test` runs successfully >- Example pipelineruns executed manually with success > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

grdryn commented 6 months ago

Going to close and re-open in an attempt to get GitHub to automatically update the PR view (it's out of date and showing a commit that's already on main).

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/217): >This PR stacks upon #215 as another preparatory commit for [RHOAIENG-1119](https://issues.redhat.com//browse/RHOAIENG-1119). It will be held until that one is merged, but it can still be reviewed, by just reviewing the new commit(s). > >## Description >With this change, we now get info for the image from the image metadata using `skopeo inspect`, rather than from the ImageStream resource in OpenShift. > >## How Has This Been Tested? > > > >- `make go-test` runs successfully >- Example pipelineruns executed manually with success > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

grdryn commented 6 months ago

Going to close and re-open in an attempt to get GitHub to automatically update the PR view (it's out of date and showing a commit that's already on main).

Wow, that actually worked. This commit should now be even easier to review

grdryn commented 6 months ago

/retest

Sara4994 commented 6 months ago

/lgtm

grdryn commented 6 months ago

@Sara4994 thanks for the review! You don't need to wait for the test status check to go green before adding the /lgtm (or approve using the review feature), since it won't automatically merge until it has both the lgtm label and the test job passes. So please just /lgtm :slightly_smiling_face:

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn, Sara4994

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

grdryn commented 6 months ago

/retest

grdryn commented 6 months ago

/retest

grdryn commented 6 months ago

/retest

opendatahub-io / ai-edge