Closed grdryn closed 7 months ago
@grdryn: This pull request references RHOAIENG-2758 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: grdryn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold until #215 and #217 are reviewed and merged.
@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
Looks good to me too. @grdryn just a quick question, the candidate
tag in the bike-rental pipeline run is just for an example right?
Also, should I go ahead and add a /lgtm
?
@biswassri you're absolutely welcome to add /lgtm here too :slightly_smiling_face: It won't get merged until either the ci/prow/test-ai-edge
check passes, or we explicitly skip it.
Looks good to me too. @grdryn just a quick question, the candidate tag in the bike-rental pipeline run is just for an example right?
Yes, both of our PipelineRun files are just examples, so the value for the candidate tag that I've added to them (they both have the same value) is just adding to the examples. You are welcome to change it to any other sane value in any other registry/repo/tag, as long as the pipeline service account has access to be able to push there (done by linking a secret, typically).
/lgtm
@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
/unhold
This PR stacks upon #215 and #217. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is the main change for the RHOAIENG-1119.
Description
This will allow overriding the internal image registry reference, and use any other image registry, repo, and tag instead.
There's a default set for the new param to maintain the old behaviour, and the same value is set in the example PipelineRun files by default.
How Has This Been Tested?
make go-test
run successfullyquay.io/grdryn/$(params.model-name):$(params.model-version)-candidate
, proving that an external registry can easily be used for the candidate image, as can be seen in the following screenshot (see tag1-candidate
):Merge criteria: