RHOAIENG-1119: Add new candidate-image-tag-reference parameter

[grdryn]

This PR stacks upon #215 and #217. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is the main change for the RHOAIENG-1119.

Description

This will allow overriding the internal image registry reference, and use any other image registry, repo, and tag instead.

There's a default set for the new param to maintain the old behaviour, and the same value is set in the example PipelineRun files by default.

How Has This Been Tested?

• make go-test run successfully
• Example pipelines run manually using default value for new parameter, proving that existing behaviour works as expected.
• Example pipelines run, with the new parameter set to quay.io/grdryn/$(params.model-name):$(params.model-version)-candidate, proving that an external registry can easily be used for the candidate image, as can be seen in the following screenshot (see tag 1-candidate):

Merge criteria:

• [x] The commits are squashed in a cohesive manner and have meaningful messages.
• [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• [x] The developer has manually tested the changes and verified that the changes work

[openshift-ci-robot]

@grdryn: This pull request references RHOAIENG-2758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/218): > >This PR stacks upon #215 and #217. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is the main change for the [RHOAIENG-2758](https://issues.redhat.com//browse/RHOAIENG-2758). > >## Description >This will allow overriding the internal image registry reference, and >use any other image registry, repo, and tag instead. > >There's a default set for the new param to maintain the old behaviour, >and the same value is set in the example PipelineRun files by default. > >## How Has This Been Tested? > > > >- `make go-test` run successfully >- Example pipelines run manually using default value for new parameter, proving that existing behaviour works as expected. >- Example pipelines run, with the new parameter set to `quay.io/grdryn/$(params.model-name):$(params.model-version)-candidate`, proving that an external registry can easily be used for the candidate image, as can be seen in the following screenshot (see tag `1-candidate`): > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[grdryn]

/hold until #215 and #217 are reviewed and merged.

[openshift-ci-robot]

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/218): > >This PR stacks upon #215 and #217. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is the main change for the [RHOAIENG-2758](https://issues.redhat.com//browse/RHOAIENG-2758). > >## Description >This will allow overriding the internal image registry reference, and >use any other image registry, repo, and tag instead. > >There's a default set for the new param to maintain the old behaviour, >and the same value is set in the example PipelineRun files by default. > >## How Has This Been Tested? > > > >- `make go-test` run successfully >- Example pipelines run manually using default value for new parameter, proving that existing behaviour works as expected. >- Example pipelines run, with the new parameter set to `quay.io/grdryn/$(params.model-name):$(params.model-version)-candidate`, proving that an external registry can easily be used for the candidate image, as can be seen in the following screenshot (see tag `1-candidate`): > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/218): > >This PR stacks upon #215 and #217. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is the main change for the [RHOAIENG-1119](https://issues.redhat.com//browse/RHOAIENG-1119). > >## Description >This will allow overriding the internal image registry reference, and >use any other image registry, repo, and tag instead. > >There's a default set for the new param to maintain the old behaviour, >and the same value is set in the example PipelineRun files by default. > >## How Has This Been Tested? > > > >- `make go-test` run successfully >- Example pipelines run manually using default value for new parameter, proving that existing behaviour works as expected. >- Example pipelines run, with the new parameter set to `quay.io/grdryn/$(params.model-name):$(params.model-version)-candidate`, proving that an external registry can easily be used for the candidate image, as can be seen in the following screenshot (see tag `1-candidate`): > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/218): > >This PR stacks upon #215 and #217. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is the main change for the [RHOAIENG-1119](https://issues.redhat.com//browse/RHOAIENG-1119). > >## Description >This will allow overriding the internal image registry reference, and >use any other image registry, repo, and tag instead. > >There's a default set for the new param to maintain the old behaviour, >and the same value is set in the example PipelineRun files by default. > >## How Has This Been Tested? > > > >- `make go-test` run successfully >- Example pipelines run manually using default value for new parameter, proving that existing behaviour works as expected. >- Example pipelines run, with the new parameter set to `quay.io/grdryn/$(params.model-name):$(params.model-version)-candidate`, proving that an external registry can easily be used for the candidate image, as can be seen in the following screenshot (see tag `1-candidate`): > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[biswassri]

Looks good to me too. @grdryn just a quick question, the candidate tag in the bike-rental pipeline run is just for an example right? Also, should I go ahead and add a /lgtm?

[grdryn]

@biswassri you're absolutely welcome to add /lgtm here too :slightly_smiling_face: It won't get merged until either the ci/prow/test-ai-edge check passes, or we explicitly skip it.

Looks good to me too. @grdryn just a quick question, the candidate tag in the bike-rental pipeline run is just for an example right?

Yes, both of our PipelineRun files are just examples, so the value for the candidate tag that I've added to them (they both have the same value) is just adding to the examples. You are welcome to change it to any other sane value in any other registry/repo/tag, as long as the pipeline service account has access to be able to push there (done by linking a secret, typically).

[biswassri]

/lgtm

[openshift-ci-robot]

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/218): > >This PR stacks upon #215 and #217. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is the main change for the [RHOAIENG-1119](https://issues.redhat.com//browse/RHOAIENG-1119). > >## Description >This will allow overriding the internal image registry reference, and >use any other image registry, repo, and tag instead. > >There's a default set for the new param to maintain the old behaviour, >and the same value is set in the example PipelineRun files by default. > >## How Has This Been Tested? > > > >- `make go-test` run successfully >- Example pipelines run manually using default value for new parameter, proving that existing behaviour works as expected. >- Example pipelines run, with the new parameter set to `quay.io/grdryn/$(params.model-name):$(params.model-version)-candidate`, proving that an external registry can easily be used for the candidate image, as can be seen in the following screenshot (see tag `1-candidate`): > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[grdryn]

/unhold