search

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
9 stars 18 forks source link

RHOAIENG-1119: Update result names that assume "internal" image #219

Closed grdryn closed 6 months ago

grdryn commented 6 months ago

~This PR stacks upon #215, #217, and #218. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s).~ This PR is an cleanup change to keep the result names meaningful.

JIRA: https://issues.redhat.com/browse/RHOAIENG-1119

Description

The following result name changes are included in this change; because the image is not necessarily internal any longer, and/or the properties are not specific to the candidate image:

How Has This Been Tested?

Merge criteria:

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-2758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/219): > >This PR stacks upon #215, #217, and #218. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is an cleanup change to keep the result names meaningful. > >JIRA: https://issues.redhat.com/browse/RHOAIENG-2758 > >## Description > >The following result name changes are included in this change; because >the image is not necessarily internal any longer, and/or the >properties are not specific to the candidate image: > >- `internal-registry-url` -> `candidate-image-tag-reference` >- `internal-image-url` -> `image-digest-reference` >- `internal-image-size` -> `image-size-bytes` >- `internal-image-created-at` -> `image-creation-time` > >## How Has This Been Tested? > > > >- Example PipelineRuns execute successfully > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
grdryn commented 6 months ago

/hold until #215, #217, and #218 are reviewed and merged.

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/219): > >This PR stacks upon #215, #217, and #218. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is an cleanup change to keep the result names meaningful. > >JIRA: https://issues.redhat.com/browse/RHOAIENG-2758 > >## Description > >The following result name changes are included in this change; because >the image is not necessarily internal any longer, and/or the >properties are not specific to the candidate image: > >- `internal-registry-url` -> `candidate-image-tag-reference` >- `internal-image-url` -> `image-digest-reference` >- `internal-image-size` -> `image-size-bytes` >- `internal-image-created-at` -> `image-creation-time` > >## How Has This Been Tested? > > > >- Example PipelineRuns execute successfully > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/219): > >This PR stacks upon #215, #217, and #218. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is an cleanup change to keep the result names meaningful. > >JIRA: https://issues.redhat.com/browse/RHOAIENG-1119 > >## Description > >The following result name changes are included in this change; because >the image is not necessarily internal any longer, and/or the >properties are not specific to the candidate image: > >- `internal-registry-url` -> `candidate-image-tag-reference` >- `internal-image-url` -> `image-digest-reference` >- `internal-image-size` -> `image-size-bytes` >- `internal-image-created-at` -> `image-creation-time` > >## How Has This Been Tested? > > > >- Example PipelineRuns execute successfully > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/219): > >This PR stacks upon #215, #217, and #218. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is an cleanup change to keep the result names meaningful. > >JIRA: https://issues.redhat.com/browse/RHOAIENG-1119 > >## Description > >The following result name changes are included in this change; because >the image is not necessarily internal any longer, and/or the >properties are not specific to the candidate image: > >- `internal-registry-url` -> `candidate-image-tag-reference` >- `internal-image-url` -> `image-digest-reference` >- `internal-image-size` -> `image-size-bytes` >- `internal-image-created-at` -> `image-creation-time` > >## How Has This Been Tested? > > > >- Example PipelineRuns execute successfully > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
biswassri commented 6 months ago

Looks good to me too.

grdryn commented 6 months ago

/unhold

openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/219): > >This PR stacks upon #215, #217, and #218. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s). This PR is an cleanup change to keep the result names meaningful. > >JIRA: https://issues.redhat.com/browse/RHOAIENG-1119 > >## Description > >The following result name changes are included in this change; because >the image is not necessarily internal any longer, and/or the >properties are not specific to the candidate image: > >- `internal-registry-url` -> `candidate-image-tag-reference` >- `internal-image-url` -> `image-digest-reference` >- `internal-image-size` -> `image-size-bytes` >- `internal-image-created-at` -> `image-creation-time` > >## How Has This Been Tested? > > > >- Example PipelineRuns execute successfully > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@grdryn: This pull request references RHOAIENG-1119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/219): > >~This PR stacks upon #215, #217, and #218. It will be held until those are merged, but it can still be reviewed, by just reviewing the new commit(s).~ This PR is an cleanup change to keep the result names meaningful. > >JIRA: https://issues.redhat.com/browse/RHOAIENG-1119 > >## Description > >The following result name changes are included in this change; because >the image is not necessarily internal any longer, and/or the >properties are not specific to the candidate image: > >- `internal-registry-url` -> `candidate-image-tag-reference` >- `internal-image-url` -> `image-digest-reference` >- `internal-image-size` -> `image-size-bytes` >- `internal-image-created-at` -> `image-creation-time` > >## How Has This Been Tested? > > > >- Example PipelineRuns execute successfully > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Sara4994 commented 6 months ago

/lgtm