RHOAIENG-3457: Add an inital root CLI

devguyio commented 6 months ago

Description

This PR is an initial PR for adding a basic CLI that just lists the namespaces as a validation to the functionality. Next PRs will remove that and add the first command.

It also adds make targets to build and run the CLI and run any CLI tests.

How Has This Been Tested?

Run the following make command

make cli-run

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [devguyio] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci-robot commented 6 months ago

@devguyio: This pull request references RHOAIENG-4184 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/222): > > >## Description > >This PR is a in initial PR for adding a basic CLI that just lists the namespaces. > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 6 months ago

@devguyio: This pull request references RHOAIENG-4184 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/222): > > >## Description > >This PR is an initial PR for adding a basic CLI that just lists the namespaces as a validation to the functionality. Next PRs will remove that and add the first command. > >It also adds make targets to build and run the CLI and run any CLI tests. > > >## How Has This Been Tested? > > > > >Run the following make command >```shell >make cli-run >``` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 6 months ago

@devguyio: This pull request references RHOAIENG-3457 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/222): > > >## Description > >This PR is an initial PR for adding a basic CLI that just lists the namespaces as a validation to the functionality. Next PRs will remove that and add the first command. > >It also adds make targets to build and run the CLI and run any CLI tests. > > >## How Has This Been Tested? > > > > >Run the following make command >```shell >make cli-run >``` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Sara4994 commented 6 months ago

@devguyio can we include some readme instructions on how one can install and run cli. May be basic ones to start with(same instructions we had in the gitlab repo)

devguyio commented 6 months ago

Holding this in case we decided to go with #226 instead /hold

opendatahub-io / ai-edge