opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
8 stars 17 forks source link

RHOAIENG-3458: Add a models command to the CLI #227

Closed devguyio closed 5 months ago

devguyio commented 5 months ago

Description

Add a models command that lists registered models from the model registry.

This PR is stacked on top of #222 .

How Has This Been Tested?

Merge criteria:

openshift-ci-robot commented 5 months ago

@devguyio: This pull request references RHOAIENG-3458 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/227): > > >## Description > >Add a `models` command that lists registered models from the model registry. > >This PR is stacked on top of #222 . > >## How Has This Been Tested? > > > > >- Install models registry in your kubecluster following [this video ](https://www.youtube.com/watch?v=grXnjGtDFXg) >- Port-forward port 8080 of the `modelregistry-sample` service in the namespace where you installed the model registry >```shell >kubectl port-forward services/modelregistry-sample 8080 >``` >- From the `cli` directory, run the cli using go, the URL of the model registry is set via the env var `MODEL_REGISTRY_URL` which defaults to `http://localhost:8080` . >```shell >cd cli >go run cmd/main.go >``` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
devguyio commented 5 months ago

/assign @StevenTobin @LaVLaS

openshift-ci-robot commented 5 months ago

@devguyio: This pull request references RHOAIENG-3458 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/227): > > >## Description > >Add a `models` command that lists registered models from the model registry. > >This PR is stacked on top of #222 . > >## How Has This Been Tested? > > > > >- Install models registry in your kubecluster following [this video ](https://www.youtube.com/watch?v=grXnjGtDFXg) >- Port-forward port 8080 of the `modelregistry-sample` service in the namespace where you installed the model registry >```shell >kubectl port-forward services/modelregistry-sample 8080 >``` >- From the `cli` directory, run the cli using go, the URL of the model registry is set via the env var `MODEL_REGISTRY_URL` which defaults to `http://localhost:8080` . >```shell >cd cli >go run cmd/main.go >``` >![image](https://github.com/opendatahub-io/ai-edge/assets/1930204/745a4ef4-5848-4de3-9cf4-651e7325953d) > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, Sara4994

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [devguyio] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
devguyio commented 5 months ago

@grdryn thanks for the review. This PR was merged by mistake and a lot of the comments you mentioned were addressed in #234 . Basically, the models command was refactored in #234 to use the edge client and also be ready for merge.

So I suggest that you check that PR and consider it the proposed state of the models command? wdyt?

grdryn commented 5 months ago

Yeah, for sure, I plan to get around to looking at #234 soon too. I just figured that one would make more sense once I'd seen these earlier ones (that I know you'd mentioned had been merged accidentally).