Closed devguyio closed 5 months ago
@devguyio: This pull request references RHOAIENG-3458 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
/assign @StevenTobin @LaVLaS
@devguyio: This pull request references RHOAIENG-3458 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: devguyio, Sara4994
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@grdryn thanks for the review. This PR was merged by mistake and a lot of the comments you mentioned were addressed in #234 . Basically, the models
command was refactored in #234 to use the edge client and also be ready for merge.
So I suggest that you check that PR and consider it the proposed state of the models
command? wdyt?
Yeah, for sure, I plan to get around to looking at #234 soon too. I just figured that one would make more sense once I'd seen these earlier ones (that I know you'd mentioned had been merged accidentally).
Description
Add a
models
command that lists registered models from the model registry.This PR is stacked on top of #222 .
How Has This Been Tested?
modelregistry-sample
service in the namespace where you installed the model registrycli
directory, run the cli using go, the URL of the model registry is set via the env varMODEL_REGISTRY_URL
which defaults tohttp://localhost:8080
.Merge criteria: