search

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
8 stars 17 forks source link

RHOAIENG-2787: Let ArgoCD create namespace, rather than using ACM Policy #229

Closed grdryn closed 5 months ago

grdryn commented 5 months ago

JIRA: https://issues.redhat.com/browse/RHOAIENG-2787

This is a preparatory commit for RHOAIENG-2787, as not needing to use ACM Policy will make things a little easier for non-ACM cases.

Description

This works as expected as long as the namespace is specified in the GitOps repo, and has the correct argocd.argoproj.io/managed-by label value. We already had the namespace specified in the GitOps repo, but we didn't include the label.

More information on this label can be found here: https://docs.openshift.com/gitops/1.11/argocd_instance/setting-up-argocd-instance.html

How Has This Been Tested?

Merge criteria:

openshift-ci-robot commented 5 months ago

@grdryn: This pull request references RHOAIENG-2787 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/229): > >JIRA: https://issues.redhat.com/browse/RHOAIENG-2787 > >## Description > >This works as expected as long as the namespace is specified in the >GitOps repo, and has the correct `argocd.argoproj.io/managed-by` label >value. >We already had the namespace specified in the GitOps repo, but we >didn't include the label. > >More information on this label can be found here: >https://docs.openshift.com/gitops/1.11/argocd_instance/setting-up-argocd-instance.html > >## How Has This Been Tested? > > > > >- Created both example applications through ACM successfully, and noticed that they were created as expected on the edge clusters >- Deleted both of the apps successfully on the ACM hub cluster, and noticed that all of the resources, including the namespaces, were deleted on the edge clusters. > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

@grdryn: This pull request references RHOAIENG-2787 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/229): > >JIRA: https://issues.redhat.com/browse/RHOAIENG-2787 > >This is a preparatory commit for [RHOAIENG-2787](https://issues.redhat.com//browse/RHOAIENG-2787), as not needing to use ACM Policy will make things a little easier for non-ACM cases. > >## Description > >This works as expected as long as the namespace is specified in the >GitOps repo, and has the correct `argocd.argoproj.io/managed-by` label >value. >We already had the namespace specified in the GitOps repo, but we >didn't include the label. > >More information on this label can be found here: >https://docs.openshift.com/gitops/1.11/argocd_instance/setting-up-argocd-instance.html > >## How Has This Been Tested? > > > > >- Created both example applications through ACM successfully, and noticed that they were created as expected on the edge clusters >- Deleted both of the apps successfully on the ACM hub cluster, and noticed that all of the resources, including the namespaces, were deleted on the edge clusters. > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 5 months ago

@grdryn: This pull request references RHOAIENG-2787 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/229): > >JIRA: https://issues.redhat.com/browse/RHOAIENG-2787 > >This is a preparatory commit for [RHOAIENG-2787](https://issues.redhat.com//browse/RHOAIENG-2787), as not needing to use ACM Policy will make things a little easier for non-ACM cases. > >## Description > >This works as expected as long as the namespace is specified in the >GitOps repo, and has the correct `argocd.argoproj.io/managed-by` label >value. >We already had the namespace specified in the GitOps repo, but we >didn't include the label. > >More information on this label can be found here: >https://docs.openshift.com/gitops/1.11/argocd_instance/setting-up-argocd-instance.html > >## How Has This Been Tested? > > > > >- Created both example applications through ACM successfully, and noticed that they were created as expected on the edge clusters >- Deleted both of the apps successfully on the ACM hub cluster, and noticed that all of the resources, including the namespaces, were deleted on the edge clusters. > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 5 months ago

@grdryn: This pull request references RHOAIENG-2787 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/229): > >JIRA: https://issues.redhat.com/browse/RHOAIENG-2787 > >This is a preparatory commit for [RHOAIENG-2787](https://issues.redhat.com//browse/RHOAIENG-2787), as not needing to use ACM Policy will make things a little easier for non-ACM cases. > >## Description > >This works as expected as long as the namespace is specified in the GitOps repo, and has the correct `argocd.argoproj.io/managed-by` label value. >We already had the namespace specified in the GitOps repo, but we didn't include the label. > >More information on this label can be found here: >https://docs.openshift.com/gitops/1.11/argocd_instance/setting-up-argocd-instance.html > >## How Has This Been Tested? > > > > >- Created both example applications through ACM successfully, and noticed that they were created as expected on the edge clusters >- Deleted both of the apps successfully on the ACM hub cluster, and noticed that all of the resources, including the namespaces, were deleted on the edge clusters. > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
grdryn commented 5 months ago

/test

openshift-ci[bot] commented 5 months ago

@grdryn: The /test command needs one or more targets. The following commands are available to trigger required jobs:

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/229#issuecomment-2004386444): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
grdryn commented 5 months ago

/test test-ai-edge

LaVLaS commented 5 months ago

/lgtm