RHOAIENG-4166: Add support for self signed certs in the MLOps pipeline

jackdelahunt commented 5 months ago

Description

What this does:

A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git
Documents the process and an optional step in the pipeline docs

How Has This Been Tested?

Use the e2e test provided in the repo
Update the pipeline run to use a git repo that uses SSC (ping me for a repo and a cert to use!)
Get access to that self signed cert and use it's path in the e2e tests as below

Run

make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=...  IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT=<PATH_TO_SSC> S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup

And then run

make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=...  IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT=<PATH_TO_SSC> S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description > > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Run `make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup` >- And then run `make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Run ```make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup``` >- And then run `make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Run >```make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup``` >- And then run `make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Run > > >```make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup``` > >- And then run `make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Run > > >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup >``` > >- And then run `make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Run >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup >``` > >- And then run >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test >``` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Update the pipeline run to use a git repo that uses SSC >- Get access to that self signed cert and use it's path in the e2e tests as below >- Run >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup >``` > >- And then run >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test >``` > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Update the pipeline run to use a git repo that uses SSC >- Get access to that self signed cert and use it's path in the e2e tests as below >- Run >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup >``` > >- And then run >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test >``` > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [LaVLaS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

LaVLaS commented 4 months ago

/retest

Retesting to see if failures are due to possible openshift-ci infrastructure issues

openshift-ci-robot commented 4 months ago

@jackdelahunt: This pull request references RHOAIENG-4166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230): > > >## Description >What this does: >- A self signed cert can be passed as a parameter to the MLops pipeline and can be used for use with private services throughout the pipeline, but for ones that only use git >- Documents the process and an optional step in the pipeline docs > >## How Has This Been Tested? >- Use the e2e test provided in the repo >- Update the pipeline run to use a git repo that uses SSC (ping me for a repo and a cert to use!) >- Get access to that self signed cert and use it's path in the e2e tests as below >- Run >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test-setup >``` > >- And then run >```bash >make AWS_SECRET_ACCESS_KEY=... AWS_ACCESS_KEY_ID=... S3_REGION=... S3_ENDPOINT=... IMAGE_REGISTRY_USERNAME=... IMAGE_REGISTRY_PASSWORD=... SELF_SIGNED_CERT= S3_BUCKET=... NAMESPACE=... TARGET_IMAGE_TAGS_JSON=... go-test >``` > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

LaVLaS commented 4 months ago

/override ci/prow/test-ai-edge

Ignoring the test failures since openshift-ci environment provisions will be down for an extended amount of time AND this has been verified manually

openshift-ci[bot] commented 4 months ago

@LaVLaS: Overrode contexts on behalf of LaVLaS: ci/prow/test-ai-edge

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/230#issuecomment-2047871006): >/override ci/prow/test-ai-edge > >Ignoring the test failures since openshift-ci environment provisions will be down for an extended amount of time AND this has been verified manually Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

opendatahub-io / ai-edge