opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
8 stars 17 forks source link

RHOAIENG-2787: Example of GitOps approach with ArgoCD directly, without ACM #231

Closed grdryn closed 5 months ago

grdryn commented 5 months ago

JIRA: https://issues.redhat.com/browse/RHOAIENG-2787

This PR stacks upon #229, and the commits here may change slightly, if there are changes required for that.

Description

We love OCM/ACM and recommend using it where possible, but if you've got your own multi-cluster and application management solution, and don't want to have to replace it to use the solutions in this repo, then you can instead use this as a starting point to integrate it yourself.

The steps are intended to be documented in such a way that they could be either executed manually or adapted to fit into any system.

How Has This Been Tested?

Merge criteria:

openshift-ci-robot commented 5 months ago

@grdryn: This pull request references RHOAIENG-2787 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/231): > > >JIRA: https://issues.redhat.com/browse/RHOAIENG-2787 > >This PR stacks upon #229, and the commits here may change slightly, if there are changes required for that. > >## Description > >We love OCM/ACM and recommend using it where possible, but if you've got your own multi-cluster and application management solution, and don't want to have to replace it to use the solutions in this repo, then you can instead use this as a starting point to integrate it yourself. > >The steps are intended to be documented in such a way that they could be either executed manually or adapted to fit into any system. > >## How Has This Been Tested? > > > >- [x] Existing approach using ACM continues to work as expected >- [x] Following the steps in the new docs/byo-mgmt-gitops.md document work as expected: > - [x] The example applications deploy as expected > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [LaVLaS,grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment