opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
8 stars 17 forks source link

Remove orphaned Policy and PlacementBinding references #233

Closed MarianMacik closed 5 months ago

MarianMacik commented 5 months ago

Description

Follow-up to the #229 which contained some unused references to Policy and PlacementBinding. Unfortunately kustomize doesn't fail for test patch operation if a resource doesn't exist as can be seen in kubernetes-sigs/kustomize/issues/4379.

How Has This Been Tested?

Ran kustomize before and after, there was no difference in the output, which means the removed parts were not applied.

Merge criteria:

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn, MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik,grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment