Closed devguyio closed 4 months ago
@devguyio: This pull request references RHOAIENG-3458 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@devguyio: This pull request references RHOAIENG-3458 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@devguyio: This pull request references RHOAIENG-3458 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@biswassri FYI
Can we have an Readme containing instructions to build and run the cli, also list of available commands and its syntax? it will be easy for others to try it out. wdyt?
/lint
This PR is reviewed best commit-by-commit. Instead of using the Files changed tab [...]
One drawback of this approach is that I don't seem to be able to leave inline suggestions as easily on all files; and also I don't seem to be able to mark all files as viewed, although I can for some (I presume if a file is changed in more than one commit in the PR, it can't be marked as viewed in any single one of those).
/remove-approve
(new process)
/lint
/lint
Can we have an Readme containing instructions to build and run the cli, also list of available commands and its syntax? it will be easy for others to try it out. wdyt?
@Sara4994 I added a readme.
Is the JIRA ID correct in the title? It appears to reference a closed issue RHOAIENG-3458
@grdryn The JIRA ID is correct, this can be considered a follow-up work relevant to that JIRA, which got closed when #227 was merged. Both PRs are about the models command.
We should also include this in the Makefile and in the PR check as well under the
make test
target.
@MarianMacik can you please clarify what should be included in the Makefile?
@devguyio There is a confusion around JIRA number for this PR. I see RHOAIENG-3458 is closed already.
This PR looks good to me, leaving this to Gerard and Landon now :)
Holding for other reviewers
/hold
This PR looks good to me, leaving this to Gerard and Landon now :)
And @MarianMacik
/unhold
We should also include this in the Makefile and in the PR check as well under the
make test
target.@MarianMacik can you please clarify what should be included in the Makefile?
@devguyio I meant to include cli tests under the root makefile test target.
We should also include this in the Makefile and in the PR check as well under the
make test
target.@MarianMacik can you please clarify what should be included in the Makefile?
@devguyio I meant to include cli tests under the root makefile test target.
@MarianMacik I've pushed the following changes:
rootFlag
to parentFlag
and now it means that this is a flag that will be declared by a parent so we're only interested in getting its value, not in declaring it.pkg/modelregistry
package
FindRegisteredModel
& FindModelVersion
AutoRegisterModelVersionArtifact
method to check if the model or version exist first, and create them only if they don't exist. /override ci/prow/test-ai-edge
@devguyio: Overrode contexts on behalf of devguyio: ci/prow/test-ai-edge
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: grdryn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
Using the model registry to implement the edge use case includes a lot of custom logic.
This PR adds a model registry client and an edge client as two abstractions that encapsulate such logic and can be used by the CLI directly.
This PR also refactors the models command to use the newly introduced edge client and streamlines the command design.
How Has This Been Tested?
Merge criteria: