RHOAIENG-3459: Implement images cmd

[devguyio]

[!WARNING] This PR is stacked on top of #234 by adding one extra commit. Please review #234 first and focus the review here on the last commit only.

Description

Add an images command to list & build model images.

This PR implement following odh subcommands:

• images: Lists model images from the model registry.
• images update: Updates the version image build parameters
• images build: Creates a new pipelinerun using the build params synced and stored in the model registry.

How Has This Been Tested?

cd cli
make cli-build
./odh images

./odh images update -i <model-id> -v <version-name>

./odh images build -i <model-id> -v <version-name>

Merge criteria:

• [x] The commits are squashed in a cohesive manner and have meaningful messages.
• [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• [x] The developer has manually tested the changes and verified that the changes work

[openshift-ci-robot]

@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/235): > >>[!WARNING] >> This PR is stacked on top of #234 by adding one extra commit. >> Please review #234 first and focus the review here on the last commit only. > >## Description > >Add an images command to list & build model images. > >This PR implement following odh subcommands: > >- images: Lists model images from the model registry. >- images sync: Synchronize an edge model image information with the model registry. >- images build: Creates a new pipelinerun using the build params synced and stored in the model registry. > >## How Has This Been Tested? > > > >```shell >cd cli >make cli-build >./odh images >``` > > >```shell >./odh images sync >``` > > >```shell >./odh images build >``` > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/235): > >>[!WARNING] >> This PR is stacked on top of #234 by adding one extra commit. >> Please review #234 first and focus the review here on the last commit only. > >## Description > >Add an images command to list & build model images. > >This PR implement following odh subcommands: > >- images: Lists model images from the model registry. >- images sync: Synchronize an edge model image information with the model registry. >- images build: Creates a new pipelinerun using the build params synced and stored in the model registry. > >## How Has This Been Tested? > > > >```shell >cd cli >make cli-build >./odh images >``` > > >```shell >./odh images sync >``` > > >```shell >./odh images build >``` > > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/235): > >>[!WARNING] >> This PR is stacked on top of #234 by adding one extra commit. >> Please review #234 first and focus the review here on the last commit only. > >## Description > >Add an images command to list & build model images. > >This PR implement following odh subcommands: > >- images: Lists model images from the model registry. >- images sync: Synchronize an edge model image information with the model registry. >- images build: Creates a new pipelinerun using the build params synced and stored in the model registry. > >## How Has This Been Tested? > > > >```shell >cd cli >make cli-build >./odh images >``` > > >```shell >./odh images sync >``` > > >```shell >./odh images build >``` > > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[devguyio]

/cc @biswassri

[grdryn]

/remove-approve

(new process)

[Sara4994]

@devguyio also, can we include instructions about models sync and images list commands in docs here

[devguyio]

@Sara4994 @MarianMacik

I've updated the documentation also the PR description with the new commands' syntax. I also updated the screenshot.

• The images list doesn't have "sync" column anymore, since there's no need for that anymore.
• The sync subcommand is now called update.
• The update and build subcommands use -i <model-id> -v <version-name> flags to identify the version image.

[openshift-ci-robot]

@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/235): > >>[!WARNING] >> This PR is stacked on top of #234 by adding one extra commit. >> Please review #234 first and focus the review here on the last commit only. > >## Description > >Add an images command to list & build model images. > >This PR implement following odh subcommands: > >- images: Lists model images from the model registry. >- images update: Updates the version image build parameters >- images build: Creates a new pipelinerun using the build params synced and stored in the model registry. > >## How Has This Been Tested? > > > >```shell >cd cli >make cli-build >./odh images >``` > > >```shell >./odh images update -i -v >``` > > >```shell >./odh images build -i -v >``` > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[Sara4994]

Tested images and its subcommands locally along with Model-registry, they are working as expected. Will wait until the comments here are taken care of, before approving.

[Sara4994]

@devguyio any update on this PR?

[devguyio]

Just repeating this to not get it lost. This shouldn't be needed I think. If there are no versions, the next range will be noop, right?

@MarianMacik yes, nice catch! Fixed. I also addressed all your other comments.

[devguyio]

@Sara4994 @MarianMacik @grdryn I've addressed all the comments.

[openshift-ci-robot]

@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/235): > >>[!WARNING] >> This PR is stacked on top of #234 by adding one extra commit. >> Please review #234 first and focus the review here on the last commit only. > >## Description > >Add an images command to list & build model images. > >This PR implement following odh subcommands: > >- images: Lists model images from the model registry. >- images update: Updates the version image build parameters >- images build: Creates a new pipelinerun using the build params synced and stored in the model registry. > >## How Has This Been Tested? > > > >```shell >cd cli >make cli-build >./odh images >``` > > >```shell >./odh images update -i -v >``` > > >```shell >./odh images build -i -v >``` > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[devguyio]

@Sara4994 @MarianMacik @grdryn I've addressed all the comments.

I've also updated the screenshots in the PR description.

[openshift-ci-robot]

@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/235): > >>[!WARNING] >> This PR is stacked on top of #234 by adding one extra commit. >> Please review #234 first and focus the review here on the last commit only. > >## Description > >Add an images command to list & build model images. > >This PR implement following odh subcommands: > >- images: Lists model images from the model registry. >- images update: Updates the version image build parameters >- images build: Creates a new pipelinerun using the build params synced and stored in the model registry. > >## How Has This Been Tested? > > > >```shell >cd cli >make cli-build >./odh images >``` > > >```shell >./odh images update -i -v >``` > > >```shell >./odh images build -i -v >``` > > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[devguyio]

Looks good, I will put lgtm once the addDirWorkspace is removed as it is not needed.

Removed

[Sara4994]

/lgtm

[devguyio]

/lgtm with some questions/comments inline

@grdryn comments addressed. You can view the changes here

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment