Closed devguyio closed 3 months ago
@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
/cc @biswassri
/remove-approve
(new process)
@devguyio also, can we include instructions about models sync and images list commands in docs here
@Sara4994 @MarianMacik
I've updated the documentation also the PR description with the new commands' syntax. I also updated the screenshot.
-i <model-id> -v <version-name>
flags to identify the version image.@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
Tested images and its subcommands locally along with Model-registry, they are working as expected. Will wait until the comments here are taken care of, before approving.
@devguyio any update on this PR?
Just repeating this to not get it lost. This shouldn't be needed I think. If there are no versions, the next range will be noop, right?
@MarianMacik yes, nice catch! Fixed. I also addressed all your other comments.
@Sara4994 @MarianMacik @grdryn I've addressed all the comments.
@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@Sara4994 @MarianMacik @grdryn I've addressed all the comments.
I've also updated the screenshots in the PR description.
@devguyio: This pull request references RHOAIENG-3459 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
Looks good, I will put lgtm once the
addDirWorkspace
is removed as it is not needed.
Removed
/lgtm
/lgtm with some questions/comments inline
@grdryn comments addressed. You can view the changes here
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: grdryn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
Add an images command to list & build model images.
This PR implement following odh subcommands:
How Has This Been Tested?
Merge criteria: