Closed Sara4994 closed 4 months ago
@Sara4994: This pull request references RHOAIENG-436 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@Sara4994: This pull request references RHOAIENG-436 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
As per recent discussion in the JIRA, added labels to inference container test Deployment as well.
As per recent discussion in the JIRA, added labels to inference container test Deployment as well.
I wasn't a part of the discussion but doesn't the inference container test Deployment mean this? https://github.com/opendatahub-io/ai-edge/blob/97f36c9c35b6dbd9c8237449a2a17cc8c3931fae/pipelines/tekton/aiedge-e2e/aiedge-e2e.pipeline.yaml#L223-L273
So it would mean to add labels to this Deployment and not the apps, right?
@LaVLaS are there any conventions for labels in ODH? Like should the label key have a prefix, like opendatahub.io/model-name
or something? I think a prefixed label would be a little better.
EDIT:
From: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set
If the prefix is omitted, the label Key is presumed to be private to the user. Automated system components (e.g. kube-scheduler, kube-controller-manager, kube-apiserver, kubectl, or other third-party automation) which add labels to end-user objects must specify a prefix.
@LaVLaS are there any conventions for labels in ODH? Like should the label key have a prefix, like
opendatahub.io/model-name
or something? I think a prefixed label would be a little better.
That is a great suggestion for the global identifier label to separate Pipelines, Tasks, *Runs, Pods, .... that are "owned" by the ai-edge workflow. If/When we have a component name then the format would be `app.opendatahub.io/
I don't think we should block this PR for that discussion but we should add this label standard to the discussions for creating controller to manage this AI Edge application workflow
I don't think we should block this PR for that discussion but we should add this label standard to the discussions for creating controller to manage this AI Edge application workflow
Sure 👍
/approve /override ci/prow/test-ai-edge
Ignoring test failures due to extended openshift-ci environment provision issues that are preventing successful test runs
@LaVLaS: Overrode contexts on behalf of LaVLaS: ci/prow/test-ai-edge
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LaVLaS
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
This PR is a simple one to include model-name as label to the pipelineruns helping in filtering the pipelineruns based on labels and also attach model-name as part of generateName to distinguish the pipelineruns name.
How Has This Been Tested?
oc get pipelineruns -l model-name=bike-rentals-auto-ml
Merge criteria: