RHOAIENG-4731 - Test gitops-update-pipeline as a part of PR check

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases

Apache License 2.0

8 stars 17 forks source link

RHOAIENG-4731 - Test gitops-update-pipeline as a part of PR check #243

Closed MarianMacik closed 4 months ago

MarianMacik commented 4 months ago

JIRA: RHOAIENG-4731

Description

PR set:

This PR adds a PR check to check the gitops-update-pipeline. It runs the pipeline, waits for the successful completion and finally checks the content of a created pull request.

2 things will likely change:

~Repository to use for the PR checks (currently my own fork)~ Now it's redhat-rhods-qe/ai-edge-ci-test
~Account to use for the PR creation (currently my account and my personal token)~ Now it's ods-qe-test

How Has This Been Tested?

Locally and will be tested by the PR check.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

MarianMacik commented 4 months ago

/retest

MarianMacik commented 4 months ago

/retest

MarianMacik commented 4 months ago

/retest

MarianMacik commented 4 months ago

/retest

LaVLaS commented 4 months ago

@MarianMacik Do you need to wait until openshift-ci issues are resolved before we can test & merge this PR?

grdryn commented 4 months ago

/lgtm

MarianMacik commented 4 months ago

/retest

MarianMacik commented 4 months ago

/retest

MarianMacik commented 4 months ago

/retest (test job timed out)

openshift-ci[bot] commented 4 months ago

@MarianMacik: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

/test test-ai-edge

Use /test all to run all jobs.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/243#issuecomment-2058618823): >/retest (test job timed out) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

bear-redhat commented 4 months ago

/test test-ai-edge

MarianMacik commented 4 months ago

/retest

MarianMacik commented 4 months ago

/retest

MarianMacik commented 4 months ago

/hold as I still need to change credentials to use a bot account and not my personal one

MarianMacik commented 4 months ago

/unhold

MarianMacik commented 4 months ago

@grdryn @LaVLaS feel free to review. All comments should be resolved now. I also updated the links in the PR's body to the repository used for PRs and the account which creates and closes the PRs. EDIT: Added deletion of the branch when the PR is closed to not pollute the test repository.

LaVLaS commented 4 months ago

/approve

Looks good. Great job @MarianMacik

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [LaVLaS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment