RHOAIENG-3459: Images describe cmd for CLI

Sara4994 commented 4 months ago

Description

The intention of this PR is to implement a command as part of CLI that displays details of the model images. It is an incremental to the previous PR that was merged recently.

JIRA --> https://issues.redhat.com/browse/RHOAIENG-3459

How Has This Been Tested?

As first step add a model by running odh models add command, once you have models image in place then you will be able to run describe to view the image details.

./odh images describe -i <model-image-id> -v <model-version-name>

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci-robot commented 4 months ago

@Sara4994: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/247): > > >## Description > > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 4 months ago

@Sara4994: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/247): > > >## Description > >The intention of this PR is to implement a command as part of CLI that displays details of the model images, >`./odh images describe

` > >This is an incremental one, on top of [PR](https://github.com/opendatahub-io/ai-edge/pull/235) and requires couple of PR's to be merged before this. So keeping this on draft mode for now. But the "image describe" feature could be tested by run these code changes. > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 4 months ago

@Sara4994: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/247): > > >## Description > >The intention of this PR is to implement a command as part of CLI that displays details of the model images, >`./odh images describe

` > >This is an incremental one, on top of [PR](https://github.com/opendatahub-io/ai-edge/pull/235) and requires couple of [PR's([1](https://github.com/opendatahub-io/ai-edge/pull/234) [2]https://github.com/opendatahub-io/ai-edge/pull/235) to be merged before this. So keeping this on draft mode for now. But the "image describe" feature could be tested by run these code changes. > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 4 months ago

@Sara4994: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/247): > > >## Description > >The intention of this PR is to implement a command as part of CLI that displays details of the model images, >`./odh images describe

` > >This is an incremental one, on top of [PR](https://github.com/opendatahub-io/ai-edge/pull/235) and requires couple of [PR's([1](https://github.com/opendatahub-io/ai-edge/pull/234) & [2](https://github.com/opendatahub-io/ai-edge/pull/235)) to be merged before this. So keeping this on draft mode for now. But the "image describe" feature could be tested by run these code changes. > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 4 months ago

@Sara4994: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/247): > > >## Description > >The intention of this PR is to implement a command as part of CLI that displays details of the model images, >`./odh images describe

` > >This is an incremental one, on top of [PR](https://github.com/opendatahub-io/ai-edge/pull/235) and requires couple of PR's([[1](https://github.com/opendatahub-io/ai-edge/pull/234)] & [[2](https://github.com/opendatahub-io/ai-edge/pull/235)]) to be merged before this. So keeping this on draft mode for now. But the "image describe" feature could be tested by run these code changes. > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 4 months ago

@Sara4994: This pull request references RHOAIENG-3459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/247): > > >## Description > >The intention of this PR is to implement a command as part of CLI that displays details of the model images, >`./odh images describe

` > >This is an incremental one, on top of [PR](https://github.com/opendatahub-io/ai-edge/pull/235) and requires couple of PR's([[1](https://github.com/opendatahub-io/ai-edge/pull/234)] & [[2](https://github.com/opendatahub-io/ai-edge/pull/235)]) to be merged before this. So keeping this on draft mode and hold this PR for now from merging. But the "image describe" feature could be tested by run these code changes. > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 3 months ago

/lint

devguyio commented 3 months ago

Nice work, I left some comments.

grdryn commented 3 months ago

/lint

grdryn commented 3 months ago

/retest

devguyio commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / ai-edge