Closed MarianMacik closed 4 months ago
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: MarianMacik
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/override ci/prow/test-ai-edge
@MarianMacik: Overrode contexts on behalf of MarianMacik: ci/prow/test-ai-edge
@grdryn I overrode the job as it is failing still. I am currently working on fixing it in https://github.com/openshift/release/pull/51003 but I found out that there is this issue with rehearsals, so I would like to fix that first. I originally expected that the PULL_NUMBER
of a completely unrelated repository from the tests point of view (openshift/release repo) wouldn't be set but counter-intuitively it is for rehearsals. Can you give it a lgtm
?
/lgtm
Good catch
Description
I found out that rehearsals run on the openshift/release repository PR set the value of the
PULL_NUMBER
env variable of the job to the PR in the openshift/release repository. This naturally leads to a rehearsal job run failing because the pipeline is trying to fetch container files from the PR for ai-edge repository, which does not exist with thatPULL_NUMBER
(the PR exists just in the openshift/release repository). Therefore, for rehearsals we should always fetch the default, e.g. the main branch of the ai-edge repository, so the same approach we already use for nightly jobs.How Has This Been Tested?
Locally.
Merge criteria: