Don't use PR branch for rehearsals in the openshift/release repository

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases

Apache License 2.0

8 stars 17 forks source link

Don't use PR branch for rehearsals in the openshift/release repository #250

Closed MarianMacik closed 4 months ago

MarianMacik commented 4 months ago

Description

I found out that rehearsals run on the openshift/release repository PR set the value of the PULL_NUMBER env variable of the job to the PR in the openshift/release repository. This naturally leads to a rehearsal job run failing because the pipeline is trying to fetch container files from the PR for ai-edge repository, which does not exist with that PULL_NUMBER (the PR exists just in the openshift/release repository). Therefore, for rehearsals we should always fetch the default, e.g. the main branch of the ai-edge repository, so the same approach we already use for nightly jobs.

How Has This Been Tested?

Locally.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

MarianMacik commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

MarianMacik commented 4 months ago

/override ci/prow/test-ai-edge

openshift-ci[bot] commented 4 months ago

@MarianMacik: Overrode contexts on behalf of MarianMacik: ci/prow/test-ai-edge

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/250#issuecomment-2065286826): >/override ci/prow/test-ai-edge Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

MarianMacik commented 4 months ago

@grdryn I overrode the job as it is failing still. I am currently working on fixing it in https://github.com/openshift/release/pull/51003 but I found out that there is this issue with rehearsals, so I would like to fix that first. I originally expected that the PULL_NUMBER of a completely unrelated repository from the tests point of view (openshift/release repo) wouldn't be set but counter-intuitively it is for rehearsals. Can you give it a lgtm?

LaVLaS commented 4 months ago

/lgtm

Good catch