Closed devguyio closed 4 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from devguyio. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Nack.
I don't think this is a problem or needed. Per https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/ and https://kubernetes.io/docs/tasks/inject-data-application/define-interdependent-environment-variables/ the env
s get expanded with the $(VARNAME)
syntax.
Nack.
I don't think this is a problem or needed. Per https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/ and https://kubernetes.io/docs/tasks/inject-data-application/define-interdependent-environment-variables/ the
env
s get expanded with the$(VARNAME)
syntax.
Yes indeed! I completely forgot about that. Thanks.
/close
@devguyio: Closed this PR.
Description
Fixing the inference generator shell scripts. The SRVC_URL might have a wrong variable substitution syntax.
How Has This Been Tested?
Was not tested. It's pretty generic knowledge about shell variable substitution.
Merge criteria: