RHOAIENG-4703: Add e2e-tests in Go to verify the GitOps pipeline is working correctly

jackdelahunt commented 4 months ago

Description

Adds support for testing the git ops pipeline with the go e2e test suite

Verify steps

Log into a cluster with oc
Set the list of enviroment variables that are needed for running the tests for both the go-test and go-test-setup make targets. All of the required fields are listed here in the README
Run oc new-project {YOURNAMESPACE}
Run make AWS_SECRET=... AWS_ACCESS=... ... go-test-setup
Run make S3_BUCKET=... ... go-test
All tests should pass

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci-robot commented 4 months ago

@jackdelahunt: This pull request references RHOAIENG-4703 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/255): >## Description >Adds support for testing the git ops pipeline with the go e2e test suite > >## Verify steps >- Log into a cluster with `oc` >- Set the list of enviroment variables that are needed for running the tests for both the `go-test` and `go-test-setup` make targets. All of the required fields are listed [here](https://github.com/jackdelahunt/ai-edge/tree/git-ops-e2e-tests/test/e2e-tests) in the README >- Run `oc new-project {YOURNAMESPACE}` >- Run `make AWS_SECRET=... AWS_ACCESS=... ... go-test-setup` >- Run `make S3_BUCKET=... ... go-test` >- All tests should pass > >## Merge criteria: > > > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

MarianMacik commented 4 months ago

I will have a look at this tomorrow, if it is OK.

jackdelahunt commented 3 months ago

@MarianMacik I didn't actually see your final message after the review. I addressed the changes suggested and still have one suggestion still open if you want a comment on that.

Besides that I think it can be approved

biswassri commented 3 months ago

Looks good to me too. Not adding lgtm so that Marian can review before merge.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / ai-edge