Closed jackdelahunt closed 3 months ago
@jackdelahunt: This pull request references RHOAIENG-4703 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
I will have a look at this tomorrow, if it is OK.
@MarianMacik I didn't actually see your final message after the review. I addressed the changes suggested and still have one suggestion still open if you want a comment on that.
Besides that I think it can be approved
Looks good to me too. Not adding lgtm so that Marian can review before merge.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: MarianMacik
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
Adds support for testing the git ops pipeline with the go e2e test suite
Verify steps
oc
go-test
andgo-test-setup
make targets. All of the required fields are listed here in the READMEoc new-project {YOURNAMESPACE}
make AWS_SECRET=... AWS_ACCESS=... ... go-test-setup
make S3_BUCKET=... ... go-test
Merge criteria: