opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
8 stars 17 forks source link

Add a go workspace #261

Closed devguyio closed 3 months ago

devguyio commented 3 months ago

Description

Since the top-level directory of the repo isn't a Go module, it's problematic to open it in an IDE like GoLand as the expectations are that the top-level directory is a Go module. However, Go 1.18 introduced the Go workspaces concept that is perfect for our situation. Here, the top-level directory is a workspace and the cli is a Go module in that workspace.

How Has This Been Tested?

There are two ways to check if this works:

Merge criteria:

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from devguyio. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
devguyio commented 3 months ago

/close

openshift-ci[bot] commented 3 months ago

@devguyio: Closed this PR.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/261#issuecomment-2093356765): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.