test/acm: Remove Policy from kustomize

MarianMacik commented 3 months ago

Description

While going through https://github.com/opendatahub-io/ai-edge/pull/259/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R31 I found out that the make test-acm-%-generate target doesn't work because the Policy has been removed as a part of #229. This results in the following error: Error: nothing selected by Policy.[noVer].policy.open-cluster-management.io/[noName].[noNs]:metadata.name which stems from the replacement's source part.

Therefore, this PR removes the Policy targets and sources as well as patch references, which makes the make target functional again. A similar removal has already been done in https://github.com/opendatahub-io/ai-edge/pull/233.

How Has This Been Tested?

From the root of the repository run:

make GIT_REPO_URL="https\://github.com/opendatahub-io/ai-edge" GIT_BRANCH=my-git-branch CUSTOM_PREFIX=custom- CUSTOM_APP_NAMESPACE=custom-tensorflow-housing test-acm-bike-rental-app-generate

make GIT_REPO_URL="https\://github.com/opendatahub-io/ai-edge" GIT_BRANCH=my-git-branch CUSTOM_PREFIX=custom- CUSTOM_APP_NAMESPACE=custom-tensorflow-housing test-acm-tensorflow-housing-app-generate

Both should output yaml definitions without throwing an error.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

MarianMacik commented 3 months ago

/approve (simple change)

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

MarianMacik commented 3 months ago

/lgtm

@MarianMacik one thought: given that nobody has noticed this in a couple of months, I wonder if the test-acm-%-generate target is actually still useful, or whether we should just remove it?

@grdryn That is a good question. I will present the proposal for removal in our scrum or in a channel.

opendatahub-io / ai-edge