opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
8 stars 17 forks source link

Decouple GitOps Update pipeline from aiedge-e2e #267

Closed grdryn closed 2 months ago

grdryn commented 3 months ago

JIRA: https://issues.redhat.com/browse/RHOAIENG-4982

Description

Before this change, at least one PipelineRun for the specified model name from the aiedge-e2e Pipeline needed to exist on the cluster, to be able to successfully run the GitOps Update Pipeline.

This change instead accepts the image details explicitly as parameters in the GitOps Update Pipeline, making it more robust and applicable to more scenarios.

How Has This Been Tested?

Merge criteria:

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

LaVLaS commented 2 months ago

/approved

This worked for me without issues and no requirement for a pre-existing successful pipelinerun

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [LaVLaS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment