Closed grdryn closed 2 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from grdryn. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Would we be able to simplify the code by defining the most complex tasks as kind: Task
and then just refer to them from both Pipelines?
As for making things optional, could we use somethings like optional gitops-git-server
or gitops-git-token-secret-name
to skip the parts of the Pipeline that the user might not want to run?
@MarianMacik Would we be able to do CI for both the e2e and the original Pipeline? Perhaps have the e2e create PR to one git branch (like qe) and then have another pipeline to duplicate that SHA256 in another git branch (like stage, or prod) ...
Would we be able to simplify the code by defining the most complex tasks as
kind: Task
and then just refer to them from both Pipelines?
That's already how this works: it expects the gitops-update-pipeline/tasks to be rolled out, and both pipelines refer to those (and shared ClusterTasks).
As for making things optional, could we use somethings like optional
gitops-git-server
orgitops-git-token-secret-name
to skip the parts of the Pipeline that the user might not want to run?
Yeah the new tasks here could easily be skipped by checking for existence of a value on one or more of the needed parameters.
@MarianMacik Would we be able to do CI for both the e2e and the original Pipeline? Perhaps have the e2e create PR to one git branch (like qe) and then have another pipeline to duplicate that SHA256 in another git branch (like stage, or prod) ...
@adelton Sorry, I have just noticed your comment. Yes, that could be done, of course.
JIRA: https://issues.redhat.com/browse/RHOAIENG-4982
Description
This shows what it would be like to have the aiedge-e2e pipeline also include all of the tasks from the gitops update pipeline.
There are advantages and disadvantages to this approach:
Advantages:
Disadvantages:
How Has This Been Tested?
Minimally. If this is the chosen path, I'll spend more time on it
Merge criteria: