search

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
8 stars 17 forks source link

RHOAIENG-9787: Create a manifests directory containing MLops pipeline tasks #272

Closed jackdelahunt closed 1 month ago

jackdelahunt commented 1 month ago

Description

Copies the tasks we use for the MLOps pipeline into a new manifests directory

How Has This Been Tested?

Merge criteria:

jackdelahunt commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

@jackdelahunt: This pull request references RHOAIENG-9787 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/272): > > >## Description >Copies the tasks we use for the MLOps pipeline into a new manifests directory > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
LaVLaS commented 1 month ago

Adding context to the PR from offline conversations: This is the first step to standardize and organize around a manifests/ directory with proper organization of individual artifacts that can be deployed according to their functionality. Supported pipelines and tasks that are core to the Near Edge workflow should be organized logically so that can be deployed as an individual group, just tasks VS piplines+tasks.

@jackdelahunt Since you are migrating the tasks and updating the shell tests we should also remove them from pipelines/tekton and update the existing documentation accordingly.

LaVLaS commented 1 month ago

/approve

Follow-up from offline conversation, @biswassri is going to update the README(s) in a follow-up PR to reflect that change in manifests.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [LaVLaS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
LaVLaS commented 1 month ago

/lgtm