search

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
9 stars 19 forks source link

RHOAIENG-2244: Make model location the same for every fetch type #276

Closed jackdelahunt closed 3 months ago

jackdelahunt commented 3 months ago

Description

When cloning from git we clone the whole repo and then refer to the model with modelRelativePath. When fetching from s3 we are copying the model directly which means modelRelativePath is not needed. This ticket is to make the location of the model after each fetch step the same so the following tasks do not need to change their behaviour based on the tasked used before in the pipeline.

This pr adds a new task to be used after the git fetch step to ensure the location of the model once we have moved on from fetching is in a common location.

There are other work arounds instead of adding a new task but we decided to do this as a first solution.

How Has This Been Tested?

openshift-ci-robot commented 3 months ago

@jackdelahunt: This pull request references RHOAIENG-2244 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/276): > > >## Description > > >## How Has This Been Tested? > > > > >## Merge criteria: > > > >- [ ] The commits are squashed in a cohesive manner and have meaningful messages. >- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [ ] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@jackdelahunt: This pull request references RHOAIENG-2244 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/276): >## Description >When cloning from git we clone the whole repo and then refer to the model with `modelRelativePath`. When fetching from s3 we are copying the model directly which mean `modelRelativePath` is not needed. This ticket is to make the location of the model after each fetch step the same so the following tasks do not need to change their behaviour based on the tasked used before in the pipeline. > >This pr adds a new task to be used after the git fetch step to ensure the location of the model once we have moved on from fetching is in a common location. > >## How Has This Been Tested? >- Run e2e tests as notmal >- Run shell tests as normal or wait for CI >## Merge criteria: > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jackdelahunt commented 3 months ago

/retest

openshift-ci-robot commented 3 months ago

@jackdelahunt: This pull request references RHOAIENG-2244 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/opendatahub-io/ai-edge/pull/276): >## Description >When cloning from git we clone the whole repo and then refer to the model with `modelRelativePath`. When fetching from s3 we are copying the model directly which means `modelRelativePath` is not needed. This ticket is to make the location of the model after each fetch step the same so the following tasks do not need to change their behaviour based on the tasked used before in the pipeline. > >This pr adds a new task to be used after the git fetch step to ensure the location of the model once we have moved on from fetching is in a common location. > >There are other work arounds instead of adding a new task but we decided to do this as a first solution. > >## How Has This Been Tested? >- Run e2e tests as normal >## Merge criteria: > >- [x] The commits are squashed in a cohesive manner and have meaningful messages. >- [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). >- [x] The developer has manually tested the changes and verified that the changes work > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=opendatahub-io%2Fai-edge). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jackdelahunt commented 3 months ago

/retest

biswassri commented 3 months ago

/approve Looks good to me. I had a successful pipeline run with this PR and the tensorflow-housing.pipelinerun.yaml. Not adding lgtm so that Marian can have a look too.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: biswassri, MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment