Delete unused parameters from pipeline and tasks

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases

Apache License 2.0

9 stars 19 forks source link

Delete unused parameters from pipeline and tasks #278

Closed MarianMacik closed 3 months ago

MarianMacik commented 3 months ago

Description

This removes 2 unused parameters:

current-namespace from check-model-and-containerfile-exists and kserve-download-model tasks
model-name from gitops-update-pipeline

How Has This Been Tested?

PR check

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

MarianMacik commented 3 months ago

/retest

MarianMacik commented 3 months ago

Removing these params looks fine. model-name should also be removed from the pipeline run example though for gitops

Good catch! I also realized that I need to remove current-namespace from the ai-edge-e2e and s3-fetch pipelines. It is interesting that Tekton doesn't complain about passing superfluous parameters to tasks and pipelines.

MarianMacik commented 3 months ago

/retest

MarianMacik commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment