opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases
Apache License 2.0
9 stars 18 forks source link

RHOAIENG-9803-Create a sample Git fetch pipeline in manifests #279

Closed biswassri closed 1 month ago

biswassri commented 1 month ago

Description

A pipeline that does the same as the MLops pipeline but now with just the git fetch task as the fetch method. This change also removes the aiedge-e2e-pipeline from the kustomization file. So the files remains but the pipeline is not gonna get created.

How Has This Been Tested?

Tested the changes using the below commands

oc apply -k manifests/
oc create -f pipelines/tekton/aiedge-e2e/git-fetch-tensorflow-housing.pipelinerun.yaml

Screenshot 2024-07-29 at 6 15 11 PM

Merge criteria:

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
biswassri commented 1 month ago

/retest

jackdelahunt commented 1 month ago

Prow will fail because the pipelines-test-openvino-tensorflow-housing.sh needs to be updated to use the new pipeline run. I don't think there should be any other breaking changes for that.

E2e-tests will also need to be updated

biswassri commented 1 month ago

Thanks @jackdelahunt. I was just going through them. I refer to your PR for the change points but they don't seem to have these changes. Should they be different for git?

^ignore this. Following 274 for reference.

openshift-ci[bot] commented 1 month ago

@biswassri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-ai-edge 6da7fb49795fe937c28a51541771e820cb3e188d link true /test test-ai-edge

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
biswassri commented 1 month ago

Closing out this PR, I did some naming changing incorrectly and the gitlog is getting super complex to resolve. Will replace this with a new PR and same changes.