Closed biswassri closed 2 months ago
The description and parameter name doesn't seem to match - can you make this clearer whether the full path or just the model name is needed? name: model-name type: string description: Name of the directory where the model files are stored
Just that one issue of the path and also AFAIK we can delete the old pipeline as part of this PR aswell
@jackdelahunt When you old pipeline do you mean the ai-edge-e2e pipeline or the pipeline files under tekton dir? So I removed the ai-edge-e2e pipeline from Kustomizaton file, so that it's not created as a pipeline but there for reeference. But I am okay to delete that as well.
@jackdelahunt When you old pipeline do you mean the ai-edge-e2e pipeline or the pipeline files under tekton dir? So I removed the ai-edge-e2e pipeline from Kustomizaton file, so that it's not created as a pipeline but there for reeference. But I am okay to delete that as well.
Yes the ai-edge-e2e, we can delete it outright instead of just from kustomize
@MarianMacik Done! I tried removing the aiedge-e2e pipeline file but somehow it's didn't get pushed in this commit.
@biswassri I tried to resolve the conflict and made one more commit to make git-fetch pipeline contain the same improvements as s3-fetch pipeline. All your previous commits are there, so nothing is lost. I hope it is OK.
/test test-ai-edge
@MarianMacik Thanks! I was about to close out this PR but now it looks good to me.
/retest (automation failure)
/retest
Tested with e2e tests and passed, and changes look good to me
/approve
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jackdelahunt, MarianMacik
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
@biswassri: you cannot LGTM your own PR.
/lgtm
Description
Replaces #279 A pipeline that does the same as the MLops pipeline but now with just the git fetch task as the fetch method. This change also removes the aiedge-e2e-pipeline from the kustomization file. So the files remains but the pipeline is not gonna get created.
How Has This Been Tested?
Merge criteria: