RHOAIENG-205-Define the standard terms

opendatahub-io / ai-edge

ODH integration with AI at the Edge usecases

Apache License 2.0

10 stars 19 forks source link

RHOAIENG-205-Define the standard terms #288

Closed biswassri closed 2 months ago

biswassri commented 2 months ago

JIRA: RHOAIENG-205

Description

Adding a glossary for stand terms. This is just the first set. We plan to iteratively update this terminology list. Ref: https://github.com/LaVLaS/ai-edge/blob/glossary/docs/glossary.md

I did move the doc that Landon had started but do we want to add more terminology to this?

How Has This Been Tested?

N/A

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

jackdelahunt commented 2 months ago

/lgtm

MarianMacik commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@biswassri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test-ai-edge	57c9d3e914fc4b15d7678f32db6ae3555da6c5b8	link	true	`/test test-ai-edge`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

MarianMacik commented 2 months ago

Rebase is needed

biswassri commented 2 months ago

@StevenTobin @adelton I have made the changes according to your comments, if everything looks good can any of you mark it approved?

StevenTobin commented 2 months ago

lgtm but @adelton's comments were more substantive than mine so I'll let him approve.

adelton commented 2 months ago

LGTM.

MarianMacik commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackdelahunt, MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/ai-edge/blob/main/OWNERS)~~ [MarianMacik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jackdelahunt commented 2 months ago

/lgtm