opendatahub-io / architecture-decision-records

Collection of Architectural Decision Records
Apache License 2.0
13 stars 33 forks source link

add ADR0006 first draft #12

Closed VedantMahabaleshwarkar closed 2 months ago

VedantMahabaleshwarkar commented 1 year ago

ADR for the change to create 1 route per model server. Requesting a review from @cfchase @taneem-ibrahim @andrewballantyne . ADR can be reviewed when the Acceptance Criteria listed in the ADR is met.

andrewballantyne commented 1 year ago

cc @lucferbux should be primary from the Dashboard. I'll try to review as well, but Lucas knows more about Model Serving

VedantMahabaleshwarkar commented 1 year ago

@andrewballantyne added you as a reviewer for the ADR itself as I assume Lucas will be writing the PR for the odh-dashboard side of things here.. so it would be like having him be the author and the reviewer for this ADR :) FYI @lucferbux -- will add you as a co author to the ADR since you will be contributing to this as well!

lucferbux commented 1 year ago

@andrewballantyne added you as a reviewer for the ADR itself as I assume Lucas will be writing the PR for the odh-dashboard side of things here.. so it would be like having him be the author and the reviewer for this ADR :) FYI @lucferbux -- will add you as a co author to the ADR since you will be contributing to this as well!

Mmmmmm, we might wanna define better this reviewer processs. This change is submited from the model serving side, we, as UI developers are only implementing those changes to the dashboard. In that scenario, I think the lead of each future should be the reviewer, regardless of the latter implementation (btw, I might not be the one implementing it, we create the issues and maybe someone else could step in to develop it).

So @VedantMahabaleshwarkar can you update it with me as a reviewer? I will do another rundown of the description this week.

github-actions[bot] commented 2 months ago

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 2 months ago

This PR was closed because it has been stale for 21+7 days with no activity.