opendatahub-io / architecture-decision-records

Collection of Architectural Decision Records
Apache License 2.0
13 stars 33 forks source link

ADR-DSP-0001 for DSP upgrade testing #14

Closed DharmitD closed 1 year ago

DharmitD commented 1 year ago

Description

ADR outlining the upgrade testing strategy for Data Science Pipelines. Resolves: #144

How Has This Been Tested?

Merge criteria:

anishasthana commented 1 year ago

cc @sutaakar @astefanutti

HumairAK commented 1 year ago

/lgtm

@gmfrasca / @amadhusu / @gregsheremeta can you also review/sign off on this

gregsheremeta commented 1 year ago

/lgtm

DharmitD commented 1 year ago

/lgtm

HumairAK commented 1 year ago

/hold until we figure out where to add this adr

HumairAK commented 1 year ago

this adr should have sufficient reviews/sign offs to accept it /lgtm /approve

@LaVLaS can we have this merged?

gregsheremeta commented 1 year ago

/hold

sorry, can we avoid reusing numbers?

ADR-xxxx already exists. Can we use ADR-DSP prefix?

(nitpick: would prefer we start at 1 too. My intention with 0 was for a meta-document, not an actual ADR)

DharmitD commented 1 year ago

/hold

sorry, can we avoid reusing numbers?

ADR-xxxx already exists. Can we use ADR-DSP prefix?

(nitpick: would prefer we start at 1 too. My intention with 0 was for a meta-document, not an actual ADR)

Makes sense. Updated the ADR title to have the ADR-DSP prefix and start at 1.

DharmitD commented 1 year ago

/hold

sorry, can we avoid reusing numbers?

ADR-xxxx already exists. Can we use ADR-DSP prefix?

(nitpick: would prefer we start at 1 too. My intention with 0 was for a meta-document, not an actual ADR)

Makes sense. Updated the ADR title to have the ADR-DSP prefix and start at 1.

gregsheremeta commented 1 year ago

/unhold

gregsheremeta commented 1 year ago

/approve