Add ADR-Operator-0001 for odh-manifests trainsition

opendatahub-io / architecture-decision-records

Collection of Architectural Decision Records

Apache License 2.0

13 stars 33 forks source link

Add ADR-Operator-0001 for odh-manifests trainsition #16

Closed zdtsw closed 1 year ago

zdtsw commented 1 year ago

Description

Add ADR-Operator-0001 for odh-manifests trainsition

ref: https://github.com/opendatahub-io/opendatahub-operator/issues/338

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

VaishnaviHire commented 1 year ago

@zdtsw Should we also add component requirements for ODH release manifests?

For an ODH release, we should be pulling manifests from a tag or release-branch

zdtsw commented 1 year ago

@zdtsw Should we also add component requirements for ODH release manifests? For an ODH release, we should be pulling manifests from a tag or release-branch

added into "Risk" section

zdtsw commented 1 year ago

@Jooho could you take a look ?

VaishnaviHire commented 1 year ago

/lgtm

zdtsw commented 1 year ago

still missing parts:

workbenches team @harshad16 / @atheo89 for review
dashboard team @andrewballantyne / @lucferbux

harshad16 commented 1 year ago

Read through the ADR, Thanks for the great efforts. The workbench team is in the process of getting the manifests in place. Will respond with updates and then provide my final review.

zdtsw commented 1 year ago

Read through the ADR, Thanks for the great efforts. The workbench team is in the process of getting the manifests in place. Will respond with updates and then provide my final review.

Thanks @harshad16 I think the goal for ADR is only to inform and get agreement for this proposal. Component team does not need to finalize the implementation in order to sign off ADR. As the proposed solution from operator, it provides the transition with exception for components that are not ready for the moment. Hence, leave the "How" table with "Transition finished? No"

zdtsw commented 1 year ago

FYI @RobGeada @ruivieira you might need to consider this too.

VaishnaviHire commented 1 year ago

@zdtsw This PR needs a rebase.

Jooho commented 1 year ago

/lgtm

We will start to test modelmesh manifests soon and I hope it will be done by ODH 1.11

VaishnaviHire commented 1 year ago

Hi @etirelli, can you merge this PR?