ODH-ADR-MS-0001: KServe Private Endpoint

opendatahub-io / architecture-decision-records

Collection of Architectural Decision Records

Apache License 2.0

16 stars 36 forks source link

Closed Jooho closed 4 months ago

Jooho commented 5 months ago

Submit ADR to change kserve(knative/istio) network topology for the private endpoint of kserve.

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

Jooho commented 5 months ago

@zdtsw Could you please review this ADR?

Jooho commented 5 months ago

@ReToCode I know you commented "approved" but could you please approve PR like other people did? (refer the last part of this PR)

zdtsw commented 4 months ago

Approved

Based on this PR https://github.com/opendatahub-io/opendatahub-operator/pull/1056 ended to bring the templates in Operator git repo. As for the solution itself, I do not have much to say about.

Jooho commented 4 months ago

@LaVLaS This ADR got all the approval from each team. Could you please review this and merge it?