search

opendatahub-io / caikit-nlp-client

A grpc and http client library for caikit-nlp
Apache License 2.0
3 stars 6 forks source link

Improve grpc error handling #36

Closed dtrifiro closed 12 months ago

dtrifiro commented 1 year ago

Improve error handling on different failure scenarios

codecov[bot] commented 12 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (122da0f) 80.25% compared to head (9ba94b7) 79.34%.

Files Patch % Lines
src/caikit_nlp_client/grpc_client.py 72.72% 6 Missing :warning:
tests/test_grpc_client.py 68.42% 5 Missing and 1 partial :warning:
tests/fixtures/http.py 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== - Coverage 80.25% 79.34% -0.92% ========================================== Files 13 13 Lines 542 581 +39 Branches 111 117 +6 ========================================== + Hits 435 461 +26 - Misses 88 100 +12 - Partials 19 20 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.