search

opendatahub-io / caikit-nlp-client

A grpc and http client library for caikit-nlp
Apache License 2.0
3 stars 6 forks source link

fix(tests): :zap: improve http client error handling #65

Closed z103cb closed 11 months ago

z103cb commented 11 months ago

Added additional logic to deal with exceptions being thrown in HTTP Code.

Fixes #60

codecov[bot] commented 11 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (1a1ddf7) 92.18% compared to head (d8d163a) 78.63%.

Files Patch % Lines
src/caikit_nlp_client/http_client.py 26.66% 10 Missing and 1 partial :warning:
tests/test_http_client.py 50.00% 8 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## =========================================== - Coverage 92.18% 78.63% -13.55% =========================================== Files 13 13 Lines 614 646 +32 Branches 121 129 +8 =========================================== - Hits 566 508 -58 - Misses 31 116 +85 - Partials 17 22 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dtrifiro commented 11 months ago

Ignoring the codecov issues for now