opendatahub-io / caikit-nlp-client

A grpc and http client library for caikit-nlp
Apache License 2.0
3 stars 6 forks source link

http client: add insecure kwarg #71

Closed dtrifiro closed 11 months ago

dtrifiro commented 11 months ago

Makes the API more symmetric by allowing insecure https requests using insecure=True

codecov[bot] commented 11 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6e187f1) 91.48% compared to head (b596d64) 91.23%.

Files Patch % Lines
src/caikit_nlp_client/http_client.py 66.66% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #71 +/- ## ========================================== - Coverage 91.48% 91.23% -0.25% ========================================== Files 13 13 Lines 646 662 +16 Branches 129 134 +5 ========================================== + Hits 591 604 +13 - Misses 37 39 +2 - Partials 18 19 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.