search

opendatahub-io / caikit-nlp-client

A grpc and http client library for caikit-nlp
Apache License 2.0
3 stars 6 forks source link

Make GrpcClient accepting filepaths instead of certificate/keys bytes #74

Closed bdattoma closed 11 months ago

bdattoma commented 11 months ago

HttpClient requires users to pass the filepath for their CA certificate, while GrpcClient requires the bytes. In order to keep consistency between the 2 clients, would it be possible to make GrpcClient working with filepath?

I guess we can read the certificates just before calling ssl_channel_credentials here