[P0] [SPIKE] Caikit or TGIS update should have no impact on customer

opendatahub-io / caikit

Caikit is an AI toolkit that enables users to manage models through a set of developer friendly APIs.

Apache License 2.0

0 stars 4 forks source link

[P0] [SPIKE] Caikit or TGIS update should have no impact on customer #12

Closed heyselbi closed 9 months ago

heyselbi commented 10 months ago

From req doc:

Upon update to new version, there should be no change for existing customers (eg. disabled by default)

[ ] verify what is expected behavior
[ ] test it
[ ] write instructions

heyselbi commented 9 months ago

Caikit-TGIS image update has been tested with QE (Berto) - image is updated only for new deployments - not current ones.

heyselbi commented 9 months ago

Need to define expected behavior.

israel-hdez commented 9 months ago

How is this different from opendatahub-io/caikit-tgis-serving#11 ?

heyselbi commented 9 months ago

@israel-hdez I believe that one tests the Caikit+TGIS image. This needs to ensure that no impact is with all three images: Caikit+TGIS, Caikit, TGIS.

israel-hdez commented 9 months ago

Upgrades that are in-place would be discouraged. If the upgrade is done as suggested here, an upgrade should not have any impact on any model/server that is already deployed. The user would need to create new deployments and gradually move their apps to the new version.

Caikit and TGIS should follow that same recommendation, so I think this ticket should use the same solution as in opendatahub-io/caikit-tgis-serving#11.

israel-hdez commented 9 months ago

I will close this issue on the understanding that we may want to follow the upgrade procedure described here: https://github.com/opendatahub-io/caikit-tgis-serving/issues/11#issuecomment-1731701003. Upgrading that way should lead to minimal impact on users.