search

opendatahub-io / data-science-pipelines-operator

Apache License 2.0
11 stars 47 forks source link

disable gke metadata in kfp ui #657

Closed HumairAK closed 3 months ago

HumairAK commented 3 months ago

this disables the gke ui bits from loading in the kfp ui

dsp-developers commented 3 months ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-657 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/657/head
git checkout -b pullrequest d19a51128218a586d14494b5d5f69778ee10730a
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-657"

More instructions here on how to deploy and test a Data Science Pipelines Application.

rimolive commented 3 months ago

/lgtm /approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [rimolive] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rimolive commented 3 months ago

/hold

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-657

rimolive commented 3 months ago

/unhold

rimolive commented 3 months ago

/lgtm