search

opendatahub-io / data-science-pipelines-operator

Apache License 2.0
12 stars 49 forks source link

Update go toolset version to 1.21 #659

Closed DharmitD closed 4 months ago

DharmitD commented 4 months ago

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-8475

Description of your changes:

Testing instructions

Checklist

dsp-developers commented 4 months ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-659 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/659/head
git checkout -b pullrequest aad9e396fb2a3cd41f02d5627c54d1bde21db489
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-659"

More instructions here on how to deploy and test a Data Science Pipelines Application.

openshift-ci[bot] commented 4 months ago

@DharmitD: you cannot LGTM your own PR.

In response to [this](https://github.com/opendatahub-io/data-science-pipelines-operator/pull/659#pullrequestreview-2118471005): >/lgtm >/Approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dsp-developers commented 4 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-659

HumairAK commented 4 months ago

/lgtm /approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/OWNERS)~~ [DharmitD,HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment